Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issue of Method normalize with return type '' is different to return type 'ArrayObject|array<array-key, mixed>|null|scalar' of inherited method NormalizerInterface::normalize #387

Closed
wants to merge 5 commits into from
Closed

Fixes issue of Method normalize with return type '' is different to return type 'ArrayObject|array<array-key, mixed>|null|scalar' of inherited method NormalizerInterface::normalize #387

wants to merge 5 commits into from

Conversation

kedarkhaire
Copy link
Collaborator

Fixes #383

@kedarkhaire
Fixes issue of Method normalize with return type '' is different to r…
449ff5b 
…eturn type 'ArrayObject|array<array-key, mixed>|null|scalar' of inherited method NormalizerInterface::normalize
@kedarkhaire kedarkhaire added this to the 3.0.8 milestone Oct 15, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.68%. Comparing base (f43f83e) to head (2a47677).
Report is 3 commits behind head on 4.x.

Files with missing lines Patch % Lines
.../Api/ApigeeX/Normalizer/RatePlanRateNormalizer.php 0.00% 1 Missing ⚠️
...rmalizer/LegalEntityReportDefinitionNormalizer.php 0.00% 1 Missing ⚠️
src/Normalizer/CredentialProductNormalizer.php 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                4.x     #387      +/-   ##
============================================
- Coverage     86.81%   86.68%   -0.14%     
+ Complexity     1768     1737      -31     
============================================
  Files           349      343       -6     
  Lines          4643     4220     -423     
============================================
- Hits           4031     3658     -373     
+ Misses          612      562      -50
Flag Coverage Δ
unittests 86.68% <91.66%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../ApigeeX/Normalizer/AcceptedRatePlanNormalizer.php 100.00% <100.00%> (ø)
...rc/Api/ApigeeX/Normalizer/ApiProductNormalizer.php 100.00% <100.00%> (ø)
...pigeeX/Normalizer/AppGroupMembershipNormalizer.php 100.00% <100.00%> (ø)
src/Api/ApigeeX/Normalizer/AppNormalizer.php 100.00% <100.00%> (ø)
...c/Api/ApigeeX/Normalizer/BillingTypeNormalizer.php 100.00% <100.00%> (ø)
src/Api/ApigeeX/Normalizer/RatePlanNormalizer.php 70.00% <100.00%> (ø)
...i/ApigeeX/Normalizer/RatePlanNormalizerFactory.php 100.00% <100.00%> (ø)
.../ApigeeX/Normalizer/StandardRatePlanNormalizer.php 100.00% <100.00%> (ø)
.../Management/Normalizer/AppCredentialNormalizer.php 100.00% <100.00%> (ø)
src/Api/Management/Normalizer/AppNormalizer.php 100.00% <100.00%> (ø)
... and 26 more

... and 99 files with indirect coverage changes

@kedarkhaire kedarkhaire modified the milestones: 3.0.8, 4.0.0 Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giteshk giteshk Awaiting requested review from giteshk

@shishir-intelli shishir-intelli Awaiting requested review from shishir-intelli

@divya-intelli divya-intelli Awaiting requested review from divya-intelli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@kedarkhaire